Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podman custom port mapping #6729

Merged
merged 8 commits into from
Apr 18, 2023
Merged

Podman custom port mapping #6729

merged 8 commits into from
Apr 18, 2023

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes part of #6479

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 11, 2023
@netlify
Copy link

netlify bot commented Apr 11, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e48e03c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/643d6e63ac8c0e00080d2744

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

NoCluster Tests on commit 0a29651 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 0a29651 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

Unit Tests on commit 0a29651 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

Validate Tests on commit 0a29651 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

Kubernetes Tests on commit 0a29651 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

Windows Tests (OCP) on commit 0a29651 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

OpenShift Tests on commit 0a29651 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 11, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 7a72134 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the podman-custom-port-mapping branch 4 times, most recently from 2b4e5dc to 9cde7c3 Compare April 12, 2023 13:30
@valaparthvi valaparthvi reopened this Apr 13, 2023
@valaparthvi
Refactor integration test
486c0a0 
Signed-off-by: Parthvi Vala <[email protected]>

Add dev --debug integration test for podman

Signed-off-by: Parthvi Vala <[email protected]>

Add dev --debug integration test for podman

Signed-off-by: Parthvi Vala <[email protected]>

Fix ci failures

Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi valaparthvi changed the title WIP: Podman custom port mapping Podman custom port mapping Apr 13, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 13, 2023
@valaparthvi valaparthvi requested review from rm3l and removed request for rnapoles-rh April 17, 2023 10:11
@valaparthvi valaparthvi reopened this Apr 17, 2023
@valaparthvi valaparthvi reopened this Apr 17, 2023
rm3l
rm3l reviewed Apr 17, 2023
View reviewed changes
pkg/dev/podmandev/pod.go Outdated Show resolved Hide resolved
tests/integration/cmd_dev_debug_test.go Outdated Show resolved Hide resolved
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 17, 2023
@danilo-gemoli
Copy link

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023

@danilo-gemoli: The following commands are available to trigger required jobs:

  • /test v4.10-images
  • /test v4.11-images
  • /test v4.12-images
  • /test v4.13-images

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danilo-gemoli
Copy link

/test v4.13-images

@valaparthvi valaparthvi reopened this Apr 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@valaparthvi
Copy link
Contributor Author

valaparthvi commented Apr 18, 2023 •
edited
Loading

OC Failure:

  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc0004b0900>: {
          Op: "Post",
          URL: "http://127.0.0.1:40605/api/newuser",
          Err: <*errors.errorString | 0xc0001120f0>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:319 @ 04/17/23 17:05:29.036
------------------------------
•••
------------------------------
• [155.973 seconds]
E2E Test starting with non-empty Directory should verify developer workflow from non-empty Directory
/go/odo_1/tests/e2escenarios/e2e_test.go:193

Windows failure:

  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2755863206
  Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2755863206 on attempt #11, trying again...
  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3716/tests/helper/helper_filesystem.go:45 @ 04/17/23 11:39:46.436
  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc000754030>: {
          Op: "Post",
          URL: "http://127.0.0.1:57457/api/newuser",
          Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3716/tests/e2escenarios/e2e_test.go:319 @ 04/17/23 11:37:40.151

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3716/tests/e2escenarios/e2e_test.go:319

Ran 7 of 7 Specs in 207.485 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

@valaparthvi
Copy link
Contributor Author

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 28ba3df into redhat-developer:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.10.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@valaparthvi @danilo-gemoli @rm3l @openshift-merge-robot