-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve the airgap env preparation script [RHIDP-1442][RHIDP-4415] #705
base: main
Are you sure you want to change the base?
chore: Improve the airgap env preparation script [RHIDP-1442][RHIDP-4415] #705
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9ec9224
to
71d15f5
Compare
d15754f
to
71379e2
Compare
71379e2
to
d9b7010
Compare
d9b7010
to
6f15425
Compare
/cc @zdrapela |
Image names should follow this format: <project>/<name>
…d compatible manner)
…P registry It works by adding the pull secrets to the namespace default service account. So it will only work when creating the CR in the operator namespace. Otherwise, we are displaying the instructions for different namespaces
This is useful if users want to explicitly use `oc-mirror` as their tool of choice and they know they are already on OCP TBD: this currently does not work with the internal OCP registry when autodetected by the script
Otherwise tools like 'skopeo login' will attempt to write to /run, which might be restricted in CI environments. This also ensures that the credentials don't conflict with any existing creds for the same registry. Co-authored-by: Zbynek Drapela <[email protected]>
This reverts commit c02beca.
This reverts commit c6dc186.
Otherwise tools like 'skopeo login' will attempt to write to /run, which might be restricted in CI environments. Since the user is required to be logged into the index image registry (and the target mirror registry eventually), it also makes sure these auth information are not lost when switching to a temporary auth file.
Otherwise, as depicted in [1], this might cause some 403 errors to be returned to Skopeo. This fixes the behavior seen on the QE airgap bastion host. [1] https://access.redhat.com/solutions/6022011
c6dc186
to
13b5e0a
Compare
Description
This improves the airgap env preparation script so that:
It also has the option to leverage the
oc-mirror
tool since this is the recommended way to mirror on OCP.Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Follow the procedure in https://github.com/rm3l/redhat-developer-hub-operator/blob/RHIDP-4415--airgap-install-script-improvements/.rhdh/docs/airgap.adoc
Note that this introduces new options to the script, but for backward compatibility, the previous ones are preserved (but deprecated) as much as possible (except
--helper_mirror_registry_storage
,--use_existing_mirror_registry
,--prod_operator_package_name
, andprod_operator_bundle_name
, which no longer make sense here).Usage