Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make the airgap script work with CI index images #779

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 11, 2025

Description

This introduces a new '--ci-index' option, which, when set to 'true', will replace all references to the internal Red Hat registries with quay.io when extracting and rebuilding the catalog.

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Example usage:

.rhdh/scripts/prepare-restricted-environment.sh \
	--index-image quay.io/rhdh/iib:next-v4.18-x86_64 \
	--ci-index true \
	--filter-versions '*' \
	--to-registry registry.localhost:5000/my-ns

Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rm3l. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rm3l rm3l force-pushed the fix_make_airgap_script_work_with_ci_index_images branch from 416cfdc to 67be90b Compare February 11, 2025 12:56
This introduces a new '--ci-index' option, which, when set to 'true',
will replace all references
to the internal Red Hat registries with quay.io when extracting and rebuilding the catalog.
@rm3l rm3l force-pushed the fix_make_airgap_script_work_with_ci_index_images branch from 67be90b to 761abb6 Compare February 11, 2025 12:59
@rm3l rm3l merged commit 64cc1c9 into redhat-developer:main Feb 11, 2025
8 of 9 checks passed
@rm3l rm3l deleted the fix_make_airgap_script_work_with_ci_index_images branch February 11, 2025 13:02
rm3l added a commit to rm3l/redhat-developer-hub-operator that referenced this pull request Feb 14, 2025
…oper#779)

This introduces a new '--ci-index' option, which, when set to 'true',
will replace all references
to the internal Red Hat registries with quay.io when extracting and rebuilding the catalog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant