Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix image-stream in nightly jobs #2328

Merged

Conversation

albarbaro
Copy link
Collaborator

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Feb 6, 2025

Hi @albarbaro. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@albarbaro albarbaro changed the title WIP: Update utils.sh WIP: Test nightly job fix Feb 6, 2025
@albarbaro
Copy link
Collaborator Author

/ok-to-test

@albarbaro
Copy link
Collaborator Author

/test e2e-tests-nightly

@albarbaro
Copy link
Collaborator Author

/test e2e-tests-nightly

@albarbaro albarbaro changed the title WIP: Test nightly job fix fix: fix image-stream in nightly jobs Feb 7, 2025
@albarbaro albarbaro marked this pull request as ready for review February 7, 2025 13:07
@openshift-ci openshift-ci bot requested review from josephca and psrna February 7, 2025 13:07
@subhashkhileri
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Feb 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 400b0a4 into redhat-developer:main Feb 9, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants