Require Java 11 #1048
Merged
Require Java 11 #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
require-java-11
branch
from
13b5da5 to
66bd957
Compare
rgrunber
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Looks fine overall. Just missing an update at
Line 163 in f666928
lemminx is moving to Java 11, so this PR ensures that a Java 11 JRE/JDK is used to run lemminx (or uses the binary if Java 11 is not installed). This PR also updates the documentation to reflect the new Java 11 requirement. It also updates the documentation related to instructions on setting up GraalVM for locally building the binary. Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
require-java-11
branch
from
66bd957 to
bc7974a
Compare
rgrunber
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Seems fine for now.
I did run into some odd workflows where the binary gets used automatically when I tried supplying a < 11 Java version. Then when the binary failed (wasn't trusted and I didn't opt to trust it), it complained that the binary server failed and that there is no Java on the system. That last message is technically wrong because there was Java, just not a valid version 😜 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lemminx is moving to Java 11, so this PR ensures that a Java 11 JRE/JDK is used to run lemminx (or uses the binary if Java 11 is not installed).
This PR also updates the documentation to reflect the new Java 11 requirement.
It also updates the documentation related to instructions on setting up GraalVM for locally building the binary.