Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating documentation URLs #1120

Merged

Conversation

aksaswadkar
Copy link
Contributor

Partner certification documentation has been updated to use the current year as the version number. This simplifies and creates annual static links.

I believe this also solves the #1083

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 29, 2024
Copy link

openshift-ci bot commented Jan 29, 2024

Hi @aksaswadkar. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcibot
Copy link

dcibot commented Jan 29, 2024

@acornett21
Copy link
Contributor

@aksaswadkar Are you saying that the docs folks have changed their URL scheme, and it will change based on the year now? Do you know if they'll ever offer a /latest route? Also, Can you rebase off of main? That will fix the test failure. Thanks for the PR.

@aksaswadkar
Copy link
Contributor Author

Hi @acornett21 Yes, the docs URLs are based on the year now. Not sure about the /latest though.

@dcibot
Copy link

dcibot commented Jan 30, 2024

@acornett21
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, aksaswadkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@acornett21 acornett21 merged commit 4c9ea7c into redhat-openshift-ecosystem:main Jan 30, 2024
5 checks passed
@aksaswadkar aksaswadkar deleted the update_doc_URL branch January 31, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants