Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress needless introspection re-attempts #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 1, 2022

  1. Suppress needless introspection re-attempts

    Introspection has undergone a number of improvements since the early
    days, including better alignment with Ironic itself, and ultimately fixes
    in underlying virtual machine configuration for when this tooling is
    used with VMs to help prevent some issues which do crop up when using VMs
    to pretend to be baremetal, specifically the enforcement of Spanning Tree.
    
    When this legacy retry code gets invoked, a legitimate error has
    occured and needs to be investigated. We don't need this code thrasing
    the environment attempting to force the node through the process, as
    that just complicates troubleshooting.
    
    This change adds inline notes, and explicitly excludes the retry if the
    version of OSP is >=16. If nodes have failed, the playbook now also fails
    the playbook run to enable the environment to be investigated as it failed
    as opposed to an artificially changed state.
    juliakreger committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9ad31ea View commit details
    Browse the repository at this point in the history