Verify Node Ready #908
Merged
Verify Node Ready #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertKrawitz
requested changes
Sep 30, 2024
ebattat
force-pushed
the
verify_node_ready
branch
2 times, most recently
from
d939538
to
42fd518
Compare
|
@RobertKrawitz, any more comments ? |
| for node in nodes_list: | ||
| node_name, node_status = node.split() | ||
| if node_status != 'Ready': | ||
| raise NodeNotReady(node_name, node_status) |
There was a problem hiding this comment.
Cleaner to return False here, and let the caller decide whether to raise an exception.
There was a problem hiding this comment.
I think we must raise an error if one of the nodes is not ready, as this should cause a CI failure.
ebattat
force-pushed
the
verify_node_ready
branch
from
42fd518
to
2f0256f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Check the node status after the OpenShift installation or upgrade, and raise an error if any node is not in 'Ready' status. Additionally, add relevant unit tests or integration tests.
For security reasons, all pull requests need to be approved first before running any automated CI