removed ec2 run in GHA #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
reviewed
Jan 2, 2024
| @@ -45,4 +45,4 @@ def test_ebs_in_use_s3_upload(): | |||
| policy_output = 's3://test-upload-data/test' | |||
| s3operations = S3Operations(region_name='us-east-1') | |||
| ebs_in_use = EbsInUse() | |||
| assert s3operations.save_results_to_s3(policy='ec2_run', policy_output=policy_output, policy_result=ebs_in_use.run()) is None | |||
| assert s3operations.save_results_to_s3(policy='ebs_in_use', policy_output=policy_output, policy_result=ebs_in_use.run()) is None | |||
There was a problem hiding this comment.
Why did you change ec2_run to ebs_in_use?
There was a problem hiding this comment.
sorry, I made a mistake.
We are testing for the ebs_in_use. I mistakenly kept the ec2_run.
There was a problem hiding this comment.
Why not check instance_run ?
ebattat
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
removed ec2 run in GHA
For security reasons, all pull requests need to be approved first before running any automated CI