nss/renego-and-resumption-NSS-with-OpenSSL - test extension #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrc0mmand
force-pushed
the
nss-renego-and-resumption
branch
from
420527f to
7225000
Compare
tomato42
reviewed
Dec 6, 2016
| if [[ $prot == "tls1_2" ]]; then | ||
| options+=(-V tls1.0:) | ||
| else | ||
| options+=(-V tls1.0:tls1.1) | ||
| fi | ||
| options+=(-n $clnt_nickname) | ||
| rlRun -s "expect nss-client.expect ${options[*]}" | ||
| rlRun -s "${options[*]} <<< 'GET /'" |
There was a problem hiding this comment.
technically, it should be 'GET / HTTP/1.0\n\n'
| @@ -640,7 +640,7 @@ rlJournalStart | |||
| rlLogInfo "Test proper" | |||
| declare -a options=() | |||
| options+=(${SERVER_UTIL} -d sql:./nssdb/ -p 4433 -V tls1.0: | |||
| -c :${C_ID[$j]} -H 1) | |||
| -c :${C_ID[$j]} -u -H 1) | |||
There was a problem hiding this comment.
shouldn't it enable it only when session ticket is being tested?
There was a problem hiding this comment.
It should, thanks. I also found out that one resumption phase is missing the -u option completely. That should be fixed as well.
Fix:
- add missing expect scripts
- enable disabled phases
* OpenSSL-NSS (client auth)
* NSS-OpenSSL
New:
- NSS-OpenSSL renegotiation
- NSS-OpenSSL renegotiation (client auth)
- NSS-OpenSSL resumption [sessionID, ticket]
- NSS-OpenSSL resumption (client auth) [session ID, ticket]
Issues:
- NSS-OpenSSL resumption (both) fails for DHE-DSS ciphers
- OpenSSL-NSS resumption (client auth) - strsclnt doesn't like
client certs
- NSS-OpenSSL - NSS-OpenSSL with client auth
mrc0mmand
force-pushed
the
nss-renego-and-resumption
branch
from
ee4ddd5 to
beb63d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the nss/renego-and-resumption-NSS-with-OpenSSL test to cover all combinations of settings for renegotiation and resumption protocols.
What's being tested (server-client):
This PR must not be merged until following issues are resolved:
rlIsRHELfunctionrlIsCentosshould be implemented soon