Added a Regex Definition for Saudi Arabian Passports #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@othmanalikhan Excellent, this is a great sig! I will add some more for other documents like the Iqamah too! |
|
@othmanalikhan Check out #28 and v2.2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple JSON definition for Saudi Arabian passports and validated against 5 live passports.
Interestingly, although not ideal, the keyword "SAU" must be included as the alternative phrase "Kingdom of Saudi Arabia" or "Saudi Arabia" is not reliable enough because of the location/design of the phrase (the phrase is located at the very top of the passport and the font type/colour is inverted/different so isn't always picked up).
Hopefully on the long run an easier keyword to match is specific Arabic words, but for the time being "SAU" is the temporary solution with ideally little false positives.