Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Python 3.12 to test matrix and classifiers #174

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

foarsitter
Copy link
Contributor

No description provided.

@ThiefMaster
Copy link

You may want to consider updating cibuildwheel as well - I think at least v2.16.2 is needed to build cp312 wheels. IMHO it's a good idea to include this with your PR since you also declare Python 3.12 support, so it'd a bit strange if it'd still do a release without the proper wheels.

@foarsitter
Copy link
Contributor Author

Makes indeed no sense @ThiefMaster, thanks for pointing out! I updated the pull-request.

@ThiefMaster
Copy link

great, now we just need a maintainer to merge this stuff and make a release :)

👀 @chayim @badboy @pietern

@badboy
Copy link
Contributor

badboy commented Oct 31, 2023

@@ -25,7 +25,7 @@ jobs:
strategy:
max-parallel: 15
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', 'pypy-3.7', 'pypy-3.8']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.7', 'pypy-3.8']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add pypy-3.9 while here, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to commit, I have no objection.

@chayim
Copy link
Contributor

chayim commented Dec 13, 2023

Just the one comment @foarsitter. I'm happy to push to it, if you prefer.

@chayim chayim merged commit 870c0f5 into redis:master Dec 14, 2023
29 checks passed
@foarsitter
Copy link
Contributor Author

Thanks @chayim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants