Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Redis sets as Python lists #189

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Jul 3, 2024

In some (rare) cases, the sets from a Redis response contain nested types that are not hashable in Python, for example maps. To handle these cases uniformly, always return Python lists for Redis sets. The elements will still be unique, relying on the correctness of data arriving from the server.

In some (rare) cases, the sets from a Redis response contain nested
types that are not hashable in Python, for example maps. To handle these
cases uniformly, always return Python lists for Redis sets. The elements
will still be unique, relying on the correctness of data arriving from
the server.
@gerzse gerzse linked an issue Jul 3, 2024 that may be closed by this pull request
@gerzse gerzse requested a review from vladvildanov July 3, 2024 13:10
@gerzse gerzse merged commit c1eefbd into redis:master Jul 19, 2024
23 checks passed
nijel added a commit to WeblateOrg/weblate that referenced this pull request Jul 19, 2024
This might be discarded in some cases (see
redis/hiredis-py#189).
nijel added a commit to WeblateOrg/weblate that referenced this pull request Jul 19, 2024
This might be discarded in some cases (see
redis/hiredis-py#189).
nijel added a commit to WeblateOrg/weblate that referenced this pull request Jul 19, 2024
This might be discarded in some cases (see
redis/hiredis-py#189).
renovate bot pushed a commit to WeblateOrg/weblate that referenced this pull request Jul 19, 2024
This might be discarded in some cases (see
redis/hiredis-py#189).
@akx
Copy link

akx commented Aug 26, 2024

For others wondering whether this also requires changes in redis-py: yes, yes it does. See redis/redis-py#3324 & redis/redis-py#3327.

The merge commit for redis/redis-py#3324 (redis/redis-py@fd0b0d3) has been released in redis-py 5.1.0. Older versions should likely use hiredis<3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault with RESP3 map inside set
3 participants