improve the test coverage on rueidisprob #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Feb 24, 2025
rueidisprob/slidingbloomfilter.go
Outdated
| redis.call('SET', nextCounterKey, 0) | ||
| redis.call('DEL', lastRotationKey) | ||
|
|
||
| return 1 |
There was a problem hiding this comment.
Why do you need these changes?
There was a problem hiding this comment.
I prefer deleting instead of setting to zero for a cleaner, more efficient reset. Deleting ensures no leftover data affects future operations, more accurately reflects the expected state of a new filter or counter.
There was a problem hiding this comment.
If you have concern about this, i can change it.
There was a problem hiding this comment.
Let’s do it in another PR.
rueian
reviewed
Feb 24, 2025
rueidisprob/slidingbloomfilter.go
Outdated
| redis.call('SET', nextCounterKey, 0) | ||
| redis.call('DEL', lastRotationKey) | ||
|
|
||
| return 1 |
There was a problem hiding this comment.
Let’s do it in another PR.
| @@ -31,6 +31,8 @@ func TestNewSlidingBloomFilter(t *testing.T) { | |||
| t.Error(err) | |||
| } | |||
|
|
|||
| fmt.Println(bf) | |||
There was a problem hiding this comment.
Suggested change
| fmt.Println(bf) |
rueian
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #774