#48 第12回パッチ会での会話を受けて

https://scrapbox.io/redmine-patch/%E7%AC%AC12%E5%9B%9E-%E3%82%B3%E3%83%A1%E3%83%B3%E3%83%88%E3%81%AF%E7%B7%A8%E9%9B%86%E3%83%AA%E3%83%B3%E3%82%AF%E3%81%8B%E3%82%89%E3%81%A7%E3%81%AF%E3%81%AA%E3%81%8F%E3%80%81%E3%82%B3%E3%83%A1%E3%83%B3%E3%83%88%E8%BF%BD%E5%8A%A0%E7%94%A8%E3%81%AEUI%E3%81%AB%E3%81%AA%E3%81%A3%E3%81%A6%E3%81%BB%E3%81%97%E3%81%84
redmine-patch-meetup · Jul 21, 2021 · f9254cd · f9254cd
1 parent c739ef8
commit f9254cd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/views/issues/_action_menu.html.erb b/app/views/issues/_action_menu.html.erb
@@ -3,7 +3,7 @@
             :onclick => 'showAndScrollToAddNotes(); return false;',
             :class => 'icon icon-add' if @issue.editable? %>
 <%= link_to l(:button_edit), edit_issue_path(@issue),
-            :onclick => 'showAndScrollTo("update", "issue_notes"); return false;',
+            :onclick => 'showAndScrollToEditIssue("update", "issue_notes"); return false;',
             :class => 'icon icon-edit', :accesskey => accesskey(:edit) if @issue.editable? %>
 <%= link_to l(:button_log_time), new_issue_time_entry_path(@issue),
             :class => 'icon icon-time-add' if User.current.allowed_to?(:log_time, @project) %>

diff --git a/app/views/issues/_edit.html.erb b/app/views/issues/_edit.html.erb
@@ -74,7 +74,7 @@
     <%= submit_tag l(:button_submit) %>
     <%= link_to(
           l(:button_cancel), issue_path(id: @issue.id),
-          :onclick => params[:action] == 'show' ? "$('#update').hide(); return false;" : ''
+          :onclick => params[:action] == 'show' ? "window.location.reload();" : ''
         ) %>
     <%= hidden_field_tag 'prev_issue_id', @prev_issue_id if @prev_issue_id %>
     <%= hidden_field_tag 'next_issue_id', @next_issue_id if @next_issue_id %>

diff --git a/public/javascripts/application.js b/public/javascripts/application.js
@@ -29,15 +29,15 @@ function showAndScrollTo(id, focus) {
 
 function showAndScrollToEditIssue() {
   $('#update h3').show();
-  $('#attributes').show();
-  $('#log_time').show();
+  $('#attributes').show(); $('#attributes input, #attributes select').prop('disabled', false)
+  $('#log_time').show(); $('#log_time input, #log_time select').prop('disabled', false)
   showAndScrollTo('update', 'issue_notes');
 }
 
 function showAndScrollToAddNotes() {
   $('#update h3').hide();
-  $('#attributes').hide();
-  $('#log_time').hide();
+  $('#attributes').hide();$('#attributes input, #attributes select').prop('disabled', true)
+  $('#log_time').hide();$('#log_time input, #log_time select').prop('disabled', true)
   showAndScrollTo('update', 'issue_notes');
 }