Merge pull request #1066 from redpanda-data/mb/snowflake-limitation

connectors: removed converter limitation on SNOWPIPE_STREAMING
redpanda-data · Feb 2, 2024 · 27529ea · 27529ea
2 parents e724c8d + 72cac19
commit 27529ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/backend/pkg/connector/interceptor/snowflake_hook.go b/backend/pkg/connector/interceptor/snowflake_hook.go
@@ -17,10 +17,6 @@ func KafkaConnectToConsoleSnowflakeHook(response model.ValidationResponse, _ map
 		return response
 	}
 
-	if ingestion.Value.Value == "snowpipe_streaming" && converter.Value.Value != "org.apache.kafka.connect.storage.StringConverter" {
-		converter.AddValueErrors("For SNOWPIPE_STREAMING only STRING converter can be used")
-	}
-
 	return response
 }
 

diff --git a/backend/pkg/connector/interceptor/snowflake_hook_test.go b/backend/pkg/connector/interceptor/snowflake_hook_test.go
@@ -80,7 +80,7 @@ func TestKafkaConnectToConsoleSnowflakeHook(t *testing.T) {
 			},
 		},
 		{
-			name: "Should not allow snowpipe streaming for non-StringConverter",
+			name: "Should allow snowpipe streaming for non-StringConverter",
 			args: args{
 				response: model.ValidationResponse{
 					Configs: []model.ConfigDefinition{
@@ -109,9 +109,8 @@ func TestKafkaConnectToConsoleSnowflakeHook(t *testing.T) {
 					},
 					{
 						Value: model.ConfigDefinitionValue{
-							Name:   "value.converter",
-							Value:  "com.snowflake.kafka.connector.records.SnowflakeJsonConverter",
-							Errors: []string{"For SNOWPIPE_STREAMING only STRING converter can be used"},
+							Name:  "value.converter",
+							Value: "com.snowflake.kafka.connector.records.SnowflakeJsonConverter",
 						},
 					},
 				},