Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml monaco loader #1381

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Fix yaml monaco loader #1381

merged 7 commits into from
Aug 20, 2024

Conversation

rikimaru0345
Copy link
Contributor

fixes #1379

weeco
weeco reviewed Aug 15, 2024
View reviewed changes
frontend/src/config.ts Outdated Show resolved Hide resolved
sago2k8
sago2k8 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@sago2k8 sago2k8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sago2k8
Copy link
Contributor

sago2k8 commented Aug 16, 2024

Seemst that the build is failing, otherwise lgtm

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rikimaru0345 rikimaru0345 merged commit 0310a9d into master Aug 20, 2024
5 of 6 checks passed
@rikimaru0345 rikimaru0345 deleted the fix-yaml-monaco-loader branch August 20, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeco weeco weeco left review comments

@sago2k8 sago2k8 sago2k8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import monaco editor from local source again
5 participants
@rikimaru0345 @sago2k8 @CLAassistant @weeco @malinskibeniamin