-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update dependency and generate better tags #1587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
sago2k8
force-pushed
the
sj/docs/openapi-docs
branch
from
January 16, 2025 10:14
1ebe5e3
to
7cdc156
Compare
@@ -189,6 +189,10 @@ message UpdateMountTaskResponse {} | |||
// CloudStorageService implements endpoints for mounting and unmounting topics in Redpanda clusters. | |||
// Requires that you have tiered storage enabled. | |||
service CloudStorageService { | |||
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_tag) = { | |||
name: "Cloud Storage" | |||
description: "Cloud Storage operations allow you mange Redpanda topics that are stored in object storage." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
description: "Cloud Storage operations allow you mange Redpanda topics that are stored in object storage." | |
description: "Cloud Storage operations allow you to manage Redpanda topics that are stored in object storage." |
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_tag) = {description: "Manage [connectors](https://docs.redpanda.com/current/deploy/deployment-option/cloud/managed-connectors/) and interact with the Kafka Connect API."}; | ||
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_tag) = { | ||
name: "Kafka Connect" | ||
description: "Manage [connectors](https://docs.redpanda.com/redpanda-cloud/develop/managed-connectors//) and interact with the Kafka Connect API." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
description: "Manage [connectors](https://docs.redpanda.com/redpanda-cloud/develop/managed-connectors//) and interact with the Kafka Connect API." | |
description: "Manage [connectors](https://docs.redpanda.com/redpanda-cloud/develop/managed-connectors/) and interact with the Kafka Connect API." |
malinskibeniamin
approved these changes
Jan 16, 2025
Generate better tags for the services, in order to do so updating the grpc-gateway dependency was necessary Signed-off-by: Santiago Jimenez Giraldo <[email protected]>
sago2k8
force-pushed
the
sj/docs/openapi-docs
branch
from
January 16, 2025 15:39
7cdc156
to
9ca8318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate better tags for the services, in order to do so updating the grpc-gateway dependency was necessary