Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better license expiration warning #918

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jvorcak
Copy link
Collaborator

@jvorcak jvorcak commented Nov 14, 2023

Before:

Screenshot 2023-11-14 at 10 16 18

After:

Screenshot 2023-11-14 at 10 19 44

Semantically it's a warning, also in the code it's called a warning so I've changed the type.

@weeco weeco requested a review from rikimaru0345 November 14, 2023 09:54
@jvorcak jvorcak merged commit dc5421f into master Nov 14, 2023
6 checks passed
@jvorcak jvorcak deleted the feature/better-license-expiration-warning branch November 14, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants