Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Replace SkeletonText with Skeleton to fix rerenders #933

Closed
wants to merge 1 commit into from

Conversation

sago2k8
Copy link
Contributor

@sago2k8 sago2k8 commented Nov 23, 2023

This is a fix for the Chakra UI issue which causes rerendering at least twice, making Console unusable

This is a fix for the Chakra UI issue which causes rerendering at least twice, making Console unusable
@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@malinskibeniamin
Copy link
Contributor

Related to #932, but we can merge #933 first and then rebase.

@sago2k8 sago2k8 marked this pull request as ready for review November 23, 2023 13:33
@malinskibeniamin
Copy link
Contributor

malinskibeniamin commented Nov 24, 2023

we already applied this change so we can leave it out

@sago2k8 sago2k8 deleted the sj/re-render-issue branch January 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants