Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IgnorePaths #1

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

frenchfrywpepper
Copy link

Trigger a step if and only if at least one changed file matches the Path and also is not in IgnorePaths.

Trigger a step if and only if at least one changed file matches
the Path and also is not in IgnorePaths.
@ivotron
Copy link
Member

ivotron commented Sep 18, 2024

rather than merging this, we could consider opening this PR against the official repo, as this is a feature that has been requested there (see buildkite-plugins#20). we could then transition to use that instead of having this fork

@ivotron
Copy link
Member

ivotron commented Sep 18, 2024

afaik, the feature we needed that prompted the fork is already available in the offical repo, but i'm not 100%

@frenchfrywpepper
Copy link
Author

The official repo has been abandoned

@frenchfrywpepper
Copy link
Author

I see, it moved to https://github.com/buildkite-plugins/monorepo-diff-buildkite-plugin but I don't see the feature I want there.

@frenchfrywpepper
Copy link
Author

Filed https://redpandadata.atlassian.net/browse/PESDLC-2076 for your consideration about moving off this fork.

@frenchfrywpepper frenchfrywpepper merged commit 8ec3872 into master Sep 19, 2024
1 of 2 checks passed
@frenchfrywpepper frenchfrywpepper deleted the sarah/exclude-paths branch September 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants