Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha/rpk-build: test and build multi os and arch #25167

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Feb 25, 2025

jira: DEVPROD-2669

The variables in the matrix of rpk-build.yml were not used, so all matrix tests were compiled and run on linux amd64.

This PR changes the workflow to run gotestsum on:

  1. linux amd64
  2. darwin arm64

And build (cross-compile) for:

  1. linux arm64
  2. darwin amd64
  3. windows amd64
  4. windows arm64

Ref:

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@andrewhsu andrewhsu requested review from twmb and r-vasquez February 25, 2025 09:41
@andrewhsu andrewhsu force-pushed the DEVPROD-2669-fix-rpk-build branch from 7b57d3e to c701353 Compare February 25, 2025 16:32
@andrewhsu andrewhsu marked this pull request as ready for review February 25, 2025 16:37
@andrewhsu andrewhsu requested a review from a team as a code owner February 25, 2025 16:37
@andrewhsu andrewhsu requested review from gousteris and removed request for a team February 25, 2025 16:37
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this, however, I would prefer to keep testing for darwin. Leaving the test out for Windows is ok for now until we fully commit to support windows.

@andrewhsu andrewhsu force-pushed the DEVPROD-2669-fix-rpk-build branch from 86845a6 to 624cdb1 Compare February 25, 2025 17:32
@andrewhsu andrewhsu force-pushed the DEVPROD-2669-fix-rpk-build branch from 624cdb1 to c721fb2 Compare February 25, 2025 17:50
@andrewhsu
Copy link
Member Author

LGTM, thanks for doing this, however, I would prefer to keep testing for darwin. Leaving the test out for Windows is ok for now until we fully commit to support windows.

@r-vasquez i've added git commit c721fb2 to test on darwin

ready for re-review

@andrewhsu andrewhsu enabled auto-merge February 25, 2025 17:59
@andrewhsu andrewhsu disabled auto-merge February 25, 2025 17:59
@andrewhsu andrewhsu requested a review from r-vasquez February 25, 2025 18:00
@andrewhsu andrewhsu changed the title gha/rpk-build: compile multi arch; only test linux gha/rpk-build: test and build multi os and arch Feb 25, 2025
@andrewhsu andrewhsu enabled auto-merge February 25, 2025 18:00
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewhsu andrewhsu merged commit be2850e into dev Feb 25, 2025
19 checks passed
@andrewhsu andrewhsu deleted the DEVPROD-2669-fix-rpk-build branch February 25, 2025 18:07
@vbotbuildovich
Copy link
Collaborator

/backport v24.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-25167-v24.2.x-925 remotes/upstream/v24.2.x
git cherry-pick -x c21ef731b1 c721fb252d

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-25167-v24.1.x-744 remotes/upstream/v24.1.x
git cherry-pick -x c21ef731b1 c721fb252d

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants