-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha/rpk-build: test and build multi os and arch #25167
Conversation
7b57d3e
to
c701353
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this, however, I would prefer to keep testing for darwin. Leaving the test out for Windows is ok for now until we fully commit to support windows.
86845a6
to
624cdb1
Compare
624cdb1
to
c721fb2
Compare
@r-vasquez i've added git commit c721fb2 to test on darwin ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/backport v24.3.x |
/backport v24.2.x |
/backport v24.1.x |
Failed to create a backport PR to v24.2.x branch. I tried:
|
Failed to create a backport PR to v24.1.x branch. I tried:
|
jira: DEVPROD-2669
The variables in the
matrix
ofrpk-build.yml
were not used, so all matrix tests were compiled and run on linux amd64.This PR changes the workflow to run
gotestsum
on:And build (cross-compile) for:
Ref:
Backports Required
Release Notes