🐛 Fix type tests not checking files #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a sanity check, here is a failing test run with TS https://github.com/Shrugsy/redux-toolkit/runs/7532322057?check_suite_focus=true |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3223822:
|
|
Huzzah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts some changes from #2409
#2409 Updated @testing-library/user-event from
^13.1.5 -> ^14.2.0. As part of the upgrade,user-eventinternally referenced theClipboardItemtype, which was not globally available for TS versions < 4.4 (see https://stackoverflow.com/a/61505395 for more info). @FaberVitale added a declaration file to address this, but it seems to have prevented any other files being included bytsconfigexcept for the declaration file itself.Hence, the
type-testspart of the github workflow hasn't actually been checking anything.This PR reverts those changes, downgrading
user-eventback to^13.1.5, and reverting the changes totsconfig.test.json, allowing thetype-testscommand to once again check all files.Note: If anyone is able to get the
ClipboardItemtype declaration to be respected byuser-event's own declaration files, a further PR is welcome.