Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size-limit config #4415

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Fixes size-limit config to monitor bundle size changes in preparation for any potential changes we'll have to make to migrate to React 19.

Copy link

codesandbox bot commented May 16, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented May 16, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 3b9b7be
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/67c198bd9110a50009d0db8b
😎 Deploy Preview https://deploy-preview-4415--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3b9b7be:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14
Copy link
Collaborator

For what it's worth, I don't think we actually want size info for every single entry point and export possible. We intentionally only measure entry points and exports we're actually concerned about the size for.

It's less of an issue since we filter out unchanged entries, but it still feels a little spammy.

@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 43b6a99 to 723c544 Compare June 21, 2024 12:24
@markerikson
Copy link
Collaborator

Yeah, this is definitely a lot more info than we need or care about. (Also, it made the size job take 14 minutes to run.)

Is there actually a problem with the current config?

@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 764eb4e to 32e222d Compare September 4, 2024 03:30
@aryaemami59
Copy link
Contributor Author

I cut down on the size-limit config, let me know if this is still not ideal and I will try to look for another solution.

@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 4 times, most recently from bcb769b to b3fbc67 Compare September 17, 2024 16:29
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 3 times, most recently from 9d20e8b to e1ecb4c Compare September 24, 2024 12:55
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 7 times, most recently from 8d2f628 to 297a8ea Compare October 8, 2024 02:38
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 4 times, most recently from f12ca17 to bc1e685 Compare October 15, 2024 19:53
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 3 times, most recently from f7a6ba8 to 8906ae4 Compare October 26, 2024 20:58
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 8906ae4 to 7bac2a4 Compare November 6, 2024 15:30
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 3 times, most recently from 0fff6a5 to 68b3a4a Compare November 13, 2024 20:11
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 2 times, most recently from 8bbce2b to b561feb Compare December 2, 2024 23:11
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 4 times, most recently from b6e706a to 1013a90 Compare December 16, 2024 22:05
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 1013a90 to 7ed947d Compare December 23, 2024 18:23
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 7ed947d to 68c9175 Compare December 31, 2024 01:55
@markerikson
Copy link
Collaborator

@aryaemami59 what does the new output of this PR look like, and what's the diff vs the current size comments?

@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 68c9175 to 3f270eb Compare January 7, 2025 04:11
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from 3f270eb to b6f6165 Compare January 18, 2025 11:55
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from b6f6165 to aece168 Compare January 28, 2025 23:32
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch 2 times, most recently from 7a26172 to a1110ff Compare February 15, 2025 08:15
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from a1110ff to f40a0d9 Compare February 28, 2025 10:38
@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from f40a0d9 to ad224c9 Compare February 28, 2025 10:53
@@ -72,7 +72,7 @@
"@typescript-eslint/eslint-plugin": "^6",
"@typescript-eslint/parser": "^6",
"axios": "^0.19.2",
"esbuild": "^0.23.0",
"esbuild": "^0.25.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to bump esbuild to get rid of some TS errors.

@aryaemami59 aryaemami59 force-pushed the fix-size-limit-config branch from ad224c9 to 3b9b7be Compare February 28, 2025 11:06
@aryaemami59 aryaemami59 marked this pull request as ready for review February 28, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants