-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support passing an external abortsignal to createAsyncThunk #4860
base: master
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
size-limit report 📦
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 602b0cd:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would documentation about this change be in a separate CR? On that note, how would one know if their version of RTK has support for this feature? Do we put it into the docs ("Available since X.Y.Z") or is there some other mechanism? |
1a08211
to
e331ef7
Compare
@schontz added docs - we don't tend to include in the docs when a feature was added, so your best bet are the release notes. |
Got it. At any rate, TS will complain if you pass a signal on a previous version. |
closes #3924
enables calling
dispatch(myThunk(arg, { signal }))
(ordispatch(myThunk(undefined, { signal }))
if no thunk arg)