Skip to content

Commit

Permalink
Silence test logging
Browse files Browse the repository at this point in the history
  • Loading branch information
markerikson committed Dec 1, 2023
1 parent bc7a188 commit 01792bc
Showing 1 changed file with 71 additions and 74 deletions.
145 changes: 71 additions & 74 deletions test/computationComparisons.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ import { Provider, shallowEqual, useSelector } from 'react-redux'
import {
createSelector,
unstable_autotrackMemoize,
weakMapMemoize
weakMapMemoize,
defaultMemoize
} from 'reselect'

import type { OutputSelector, defaultMemoize } from 'reselect'
import type { OutputSelector } from 'reselect'
import type { RootState, Todo } from './testUtils'
import {
addTodo,
Expand Down Expand Up @@ -97,7 +98,10 @@ describe('Computations and re-rendering with React components', () => {
const selectTodoByIdResultEquality = createSelector(
[selectTodos, selectTodoId],
mapTodoById,
{ memoizeOptions: { resultEqualityCheck: shallowEqual, maxSize: 500 } }
{
memoize: defaultMemoize,
memoizeOptions: { resultEqualityCheck: shallowEqual, maxSize: 500 }
}
)

const selectTodoByIdWeakMap = createSelector(
Expand Down Expand Up @@ -176,77 +180,70 @@ describe('Computations and re-rendering with React components', () => {
]
]

test.each(testCases)(
`%s`,
async (
name,
selectTodoIds,
selectTodoById
) => {
selectTodoIds.resetRecomputations()
selectTodoIds.resetDependencyRecomputations()
selectTodoById.resetRecomputations()
selectTodoById.resetDependencyRecomputations()
selectTodoIds.memoizedResultFunc.resetResultsCount()
selectTodoById.memoizedResultFunc.resetResultsCount()

const numTodos = store.getState().todos.length
rtl.render(
<Provider store={store}>
<TodoList
selectTodoIds={selectTodoIds}
selectTodoById={selectTodoById}
/>
</Provider>
)

console.log(`Recomputations after render (${name}): `)
console.log('selectTodoIds: ')
logSelectorRecomputations(selectTodoIds as any)
console.log('selectTodoById: ')
logSelectorRecomputations(selectTodoById as any)

console.log('Render count: ', {
listRenders,
listItemRenders,
listItemMounts
})

expect(listItemRenders).toBe(numTodos)

rtl.act(() => {
store.dispatch(toggleCompleted(3))
})

console.log(`\nRecomputations after toggle completed (${name}): `)
console.log('selectTodoIds: ')
logSelectorRecomputations(selectTodoIds as any)
console.log('selectTodoById: ')
logSelectorRecomputations(selectTodoById as any)

console.log('Render count: ', {
listRenders,
listItemRenders,
listItemMounts
})

rtl.act(() => {
store.dispatch(addTodo({ title: 'a', description: 'b' }))
})

console.log(`\nRecomputations after added (${name}): `)
console.log('selectTodoIds: ')
logSelectorRecomputations(selectTodoIds as any)
console.log('selectTodoById: ')
logSelectorRecomputations(selectTodoById as any)

console.log('Render count: ', {
listRenders,
listItemRenders,
listItemMounts
})
}
)
test.each(testCases)(`%s`, async (name, selectTodoIds, selectTodoById) => {
selectTodoIds.resetRecomputations()
selectTodoIds.resetDependencyRecomputations()
selectTodoById.resetRecomputations()
selectTodoById.resetDependencyRecomputations()
selectTodoIds.memoizedResultFunc.resetResultsCount()
selectTodoById.memoizedResultFunc.resetResultsCount()

const numTodos = store.getState().todos.length
rtl.render(
<Provider store={store}>
<TodoList
selectTodoIds={selectTodoIds}
selectTodoById={selectTodoById}
/>
</Provider>
)

// console.log(`Recomputations after render (${name}): `)
// console.log('selectTodoIds: ')
// logSelectorRecomputations(selectTodoIds as any)
// console.log('selectTodoById: ')
// logSelectorRecomputations(selectTodoById as any)

// console.log('Render count: ', {
// listRenders,
// listItemRenders,
// listItemMounts
// })

expect(listItemRenders).toBe(numTodos)

rtl.act(() => {
store.dispatch(toggleCompleted(3))
})

// console.log(`\nRecomputations after toggle completed (${name}): `)
// console.log('selectTodoIds: ')
// logSelectorRecomputations(selectTodoIds as any)
// console.log('selectTodoById: ')
// logSelectorRecomputations(selectTodoById as any)

// console.log('Render count: ', {
// listRenders,
// listItemRenders,
// listItemMounts
// })

rtl.act(() => {
store.dispatch(addTodo({ title: 'a', description: 'b' }))
})

// console.log(`\nRecomputations after added (${name}): `)
// console.log('selectTodoIds: ')
// // logSelectorRecomputations(selectTodoIds as any)
// console.log('selectTodoById: ')
// // logSelectorRecomputations(selectTodoById as any)

// console.log('Render count: ', {
// listRenders,
// listItemRenders,
// listItemMounts
// })
})
})

describe('resultEqualityCheck in weakMapMemoize', () => {
Expand Down

0 comments on commit 01792bc

Please sign in to comment.