Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning in development when a result function is x => x. #645

Merged
merged 24 commits into from
Dec 1, 2023
Merged

Add warning in development when a result function is x => x. #645

merged 24 commits into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. Add initial implementation for noopCheck

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6cf53cb View commit details
    Browse the repository at this point in the history

  2. Disable no-op check for some unit tests

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a8645a0 View commit details
    Browse the repository at this point in the history

  3. Disable no-op check for performance tests

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    703bf3a View commit details
    Browse the repository at this point in the history

  4. Rename StabilityCheckFrequency to DevModeCheckFrequency

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1615733 View commit details
    Browse the repository at this point in the history

  5. Rename noopCheck to identityFunctionCheck 

    - Rename the types, functions and variables to identity function check, since noop is more like `() => {}` and identity is `x => x`
    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    cdc93c0 View commit details
    Browse the repository at this point in the history

  6. Add JSDocs for runIdentityFunctionCheck utility function.

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b25c9c9 View commit details
    Browse the repository at this point in the history

  7. Update README to include identityFunctionCheck

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ac4da4a View commit details
    Browse the repository at this point in the history

  8. Add JSDocs for setGlobalIdentityFunctionCheck

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5a53b42 View commit details
    Browse the repository at this point in the history

  9. Add JSDocs for CreateSelectorOptions.identityFunctionCheck

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    751daf3 View commit details
    Browse the repository at this point in the history

  10. Add identityFunctionCheck to v5 summary in README

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    611d833 View commit details
    Browse the repository at this point in the history

  11. Fix copy-paste error in README

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c2563d3 View commit details
    Browse the repository at this point in the history

  12. Fix JSDocs for shouldRunDevModeCheck

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    45f036a View commit details
    Browse the repository at this point in the history

  13. Fix issue with firstRun

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c05bcc5 View commit details
    Browse the repository at this point in the history

  14. Add DevModeChecks 

    - Add `DevModeChecks`, a type representing the configuration for development mode checks.
- Replace `inputStabilityCheck` and `identityFunctionCheck` inside `CreateSelectorOptions` with `devModeChecks`.
- Add `DevModeChecksExecutionInfo`, a type representing execution information for development mode checks.
- Add `setGlobalDevModeChecks`, a function allowing to override `globalDevModeChecks`.
- Create devModeChecks folder.
- Move each dev-mode-check to their own file.
- Remove `shouldRunDevModeCheck` in favor of `getDevModeChecksExecutionInfo`.
- Update unit tests to comply with these changes.
    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3a51095 View commit details
    Browse the repository at this point in the history

  15. Update README with new dev-mode-check API

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    397f3d8 View commit details
    Browse the repository at this point in the history

  16. Fix inputStabilityCheck warning message.

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    dda015b View commit details
    Browse the repository at this point in the history

  17. export setGlobalDevModeChecks in index.ts

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    df84098 View commit details
    Browse the repository at this point in the history

  18. Remove '@internal' imports

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    17718f3 View commit details
    Browse the repository at this point in the history

  19. Fix devModeChecks in type tests

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4952ad4 View commit details
    Browse the repository at this point in the history

  20. increase performance timer from 1000 to 1500

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    20a7d97 View commit details
    Browse the repository at this point in the history

  21. Change package version as a workaround

    @aryaemami59 @markerikson
    aryaemami59 authored and markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    bc7a188 View commit details
    Browse the repository at this point in the history

  22. Silence test logging

    @markerikson
    markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    01792bc View commit details
    Browse the repository at this point in the history

  23. Fix lockfile issue

    @markerikson
    markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6f3bd23 View commit details
    Browse the repository at this point in the history

  24. Fix silly types import issue

    @markerikson
    markerikson committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    ae0a921 View commit details
    Browse the repository at this point in the history