-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade Jotai to v2 and use yarn v4 #55
base: alpha
Are you sure you want to change the base?
Conversation
@@ -187,7 +188,7 @@ test("computeAtom", async () => { | |||
layer, | |||
status: "fetching", | |||
features: [...toComputedFeature(features), ...toComputedFeature(features2)], | |||
originalFeatures: [...features, ...features3], | |||
originalFeatures: [...features, ...features2], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not follows the origin idea how it should work.
I think it's coming from the upgrade Jotai to v2 around async atom maybe.
However it seems also make sense to have this result if set data is async, but if it's by design that the orignalFeatures should be updated immediatly, we need to investigate the cause and fix it.
Also i don't understand how feature2 been removed from oringalFeatures in this test.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Basically i want to alignment the yarn version within our team, so i want to use yarn v4 and solve the issues coming from it.
For better link to Visualizer i need to upgrade some dependencies, including Jotai.