-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): dockerize web application #33
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes encompass multiple workflow files in the GitHub Actions setup for building, deploying, and managing Docker images for a web application. A new job for building a legacy Docker image has been added, and existing jobs have been updated to reflect new naming conventions and image specifications. Additionally, new deployment jobs for AWS and Google Cloud Run have been introduced, along with corresponding environment variables. New Docker-related files, including a Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for reearth-classic canceled.
|
f658922
to
035fb6a
Compare
Signed-off-by: KeisukeYamashita <[email protected]>
035fb6a
to
b7a34a8
Compare
Overview
I've Dockerized the web application to be portable and deployable to container runtimes (e.g. Cloud Run, Kubernetes). We aim to host the web on Cloud Run.
What I've done
I've containerised the application and implemented the deployment workflow.
What I haven't done
I haven't decommissioned our GCS stuff yet.
I've implemented it separately from the existing system so that we can deploy, test, and switch over without any impact.
How I tested
Which point I want you to review particularly
Memo
Summary by CodeRabbit
Release Notes
New Features
.dockerignore
file to streamline Docker builds.Bug Fixes
Chores