-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): add missing brand
in Docker's config file
#38
Conversation
Signed-off-by: KeisukeYamashita <[email protected]>
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request involve the addition of a new environment variable and a corresponding property in a JSON configuration template. Specifically, the Dockerfile now includes the environment variable Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for reearth-classic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Overview
As the title says, I added a new runtime environment variable,
REEARTH_BRAND
, to configure thebrand
property in the config file.What I've done
Added
REEARTH_BRAND
as Docker environment variable and addbrand
to the config template file.What I haven't done
How I tested
Which point I want you to review particularly
Memo
Summary by CodeRabbit
REEARTH_BRAND
for enhanced configuration options."brand"
property in the JSON configuration template that utilizes the new environment variable.