-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add missing id-token:write
permission for Google Cloud
#1276
Conversation
Signed-off-by: KeisukeYamashita <[email protected]>
✅ Deploy Preview for reearth-cms canceled.
|
Signed-off-by: KeisukeYamashita <[email protected]>
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces modifications to two GitHub workflow files: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Google Cloud
User->>GitHub Actions: Trigger workflow
GitHub Actions->>GitHub Actions: Check out code (actions/checkout@v4)
GitHub Actions->>Google Cloud: Authenticate (OIDC)
GitHub Actions->>Google Cloud: Perform deployment/update tasks
Google Cloud-->>GitHub Actions: Confirm actions completed
GitHub Actions-->>User: Workflow completed
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* ci: add missing id-token permission for gc auth Signed-off-by: KeisukeYamashita <[email protected]> * ci: add missing `actions/checkout` before google cloud auth Signed-off-by: KeisukeYamashita <[email protected]> --------- Signed-off-by: KeisukeYamashita <[email protected]>
Overview
Add missing permissions to authenticate with Google Cloud with workload federation.
What I've done
What I haven't done
How I tested
Ran the workflow: log.
Looks good.
Screenshot
Which point I want you to review particularly
Memo
Summary by CodeRabbit