ci: remove web assets from API Docker image #1293
Conversation
WalkthroughThe pull request includes modifications to multiple GitHub Actions workflow files and a Dockerfile. Key changes involve the removal of artifact handling steps from the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for reearth-cms ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: KeisukeYamashita <[email protected]>
KeisukeYamashita
force-pushed
the
remove-frontend-assets-from-api
branch
from
0190e2a to
9d234f2
Compare
| with: | ||
| name: reearth-cms-web | ||
| path: web/reearth-cms-web.tar.gz | ||
| if-no-files-found: error |
There was a problem hiding this comment.
These steps can remain beccause it is helpful to investigate issue on build results.
Signed-off-by: KeisukeYamashita <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/ci_web.yml(1 hunks)
🧰 Additional context used
🪛 yamllint
.github/workflows/ci_web.yml
[error] 41-41: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
.github/workflows/ci_web.yml (1)
Line range hint 1-41: Verify dependent workflow changes.
The removal of artifact packaging and uploading steps aligns with the PR objective of separating web assets. However, let's verify that all dependent workflows have been updated accordingly.
✅ Verification successful
Update required in dependent workflows for web asset changes
The verification has revealed that several workflows still reference the web assets and need to be updated:
deploy_test.yml: References web deployment but uses Docker images, not the removed artifactbuild_web.yml: Handles Docker image building and pushing, aligned with the new approachcron_ion_token_test.yml: Only references the web service name, no artifact dependencies
The removal of artifact packaging is consistent with the shift to container-based deployments, and no workflows are attempting to download the removed artifact. The changes are safe.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining references to the removed web artifact
# Test 1: Search for workflow files that might download the web artifact
echo "Checking for workflows that attempt to download web artifacts..."
rg -l --type yaml 'reearth-cms-web' .github/workflows/
# Test 2: Search for any remaining references to the web artifact name
echo "Checking for any remaining references to the web artifact..."
rg -l 'reearth-cms-web.tar.gz' .
Length of output: 494
Script:
#!/bin/bash
# Let's examine the content of the identified workflow files to understand their dependencies
echo "=== Content of deploy_test.yml ==="
cat .github/workflows/deploy_test.yml
echo -e "\n=== Content of build_web.yml ==="
cat .github/workflows/build_web.yml
echo -e "\n=== Content of cron_ion_token_test.yml ==="
cat .github/workflows/cron_ion_token_test.yml
Length of output: 10715
🧰 Tools
🪛 yamllint
[error] 41-41: no new line character at the end of file
(new-line-at-end-of-file)
| - uses: actions/upload-artifact@v4 | ||
| if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/release' | ||
| with: | ||
| name: reearth-cms-web | ||
| path: web/reearth-cms-web.tar.gz | ||
| if-no-files-found: error | ||
| if-no-files-found: error |
There was a problem hiding this comment.
Add newline at end of file.
Add a newline character at the end of the file to comply with POSIX standards.
if-no-files-found: error
+📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if-no-files-found: error | |
| if-no-files-found: error | |
🧰 Tools
🪛 yamllint
[error] 41-41: no new line character at the end of file
(new-line-at-end-of-file)
Overview
Because the web has it's own Docker image, there is no need to include it with it in the API's Docker image.
I also remove the CI for the web (GCS).
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo
Summary by CodeRabbit
New Features
Bug Fixes
Chores