fix: EntityDescription isn't displayed well #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfarmer-ara
force-pushed
the
628-EntityDescriptionFix
branch
from
befbd5a to
d543ab5
Compare
|
Updated branch to be on latest, is this able to get merged? While we have a workaround it's not ideal. Thanks! |
628 Removes assumption that the infobox always has the bodyless class
mfarmer-ara
force-pushed
the
628-EntityDescriptionFix
branch
from
d543ab5 to
8b19963
Compare
keiya01
approved these changes
Jul 24, 2024
keiya01
changed the title
|
@mfarmer-ara We've released your change in v1.18.0. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes assumption that the infobox always has the bodyless class.
From looking at the infobox behavior it looks like the bodyless class isn't always present when you click different entities. Removing it fixed the issues detailed in #628
Tested both on my local environment using Resium as well as the story noted in the issue that exhibited similar behavior.
closes #628