fix: change imageryProvider to readonly #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lack of recreation on imageryProvider prop update by adding it to the cesiumReadonlyProps array, which is where it belongs according to the Cesium and Resium documentation. Addresses reearth#664
keiya01
approved these changes
Jul 9, 2024
keiya01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lack of
ImageryLayerrecreation onimageryProviderprop update by adding it to thecesiumReadonlyPropsarray, which is where it belongs according to the Cesium and Resium documentation.Resolves #664
One additional note: My local
yarn.lockwas full of "changes", but runningyarntold me "Migrated your project to the latest Yarn version 🚀", so I didn't commit it. I can add those changes to the PR if necessary.