Feat/#2123 upgrade dependencies client #2173
Conversation
…ly fixes to codebase
| @@ -84,7 +84,7 @@ const UserContributions = (props: Props) => { | |||
| ); | |||
| } | |||
| window.scrollTo(0, 0); | |||
| }, [dispatch]); | |||
| }, [dispatch, userStructure]); | |||
There was a problem hiding this comment.
It seems that this one is causing an infinite loop which fetch data all the time (this is probably more a bug in the code of the effect)
You can experience it by going in the backoffice, in the "Fiches" tab
There was a problem hiding this comment.
I can't reproduce this 🤔 I checked the Network tab in developer tools and it just get's the data once (twice because running in dev mode actually)
There was a problem hiding this comment.
Ok maybe something wrong with my local db. Let's try it on staging then!
| @@ -56,7 +56,7 @@ export const UserStructureComponent = (props: Props) => { | |||
| ); | |||
| } | |||
| window.scrollTo(0, 0); | |||
| }, [dispatch]); | |||
| }, [dispatch, userStructure]); | |||
There was a problem hiding this comment.
Like for the userContributions, this is causing an infinite loop.
You can see it by going to the Structure tab of the backoffice (you need to be a user with a structure for this)
There was a problem hiding this comment.
Again I can't reproduce this locally.
…o @testing-library/react
…pWithProvidersAndRenderForTesting
…les. Update .scss imports
…pening aliased scss paths in vscode
…pescript-plugin-css-modules
Sorry this is a big PR. Was originally going to split up into separate PRs but combined to get dependency upgrade done and move on to other work. Commits take this step by step and are a good source of information on the issues involved.
styledcomponentsupgrade and update codebase by typing calls tostyled.divand updating all test snapshots. Noticestyledcomponentsv6 no longer supports vendor prefixes by default since no longer required in modern browsersRemaining Major Dependency Upgrades: