Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: version bump for ledger-cosmos-go #2191

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

clevinson
Copy link
Member

Description

Fixes bug where latest Ledger Firmware + Ledger Cosmos App is incompatible with Regen Ledger.

More info: cosmos/cosmos-sdk#18319


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@clevinson clevinson added the backport/v5.1.x backport to release/v5.1.x branch label Apr 2, 2024
@clevinson clevinson requested a review from aaronc April 2, 2024 23:35
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.24%. Comparing base (0cda6aa) to head (dabcd02).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2191       +/-   ##
===========================================
- Coverage   72.93%   62.24%   -10.69%     
===========================================
  Files         243      277       +34     
  Lines       14027    16434     +2407     
===========================================
  Hits        10230    10230               
- Misses       3042     5449     +2407     
  Partials      755      755               

see 34 files with indirect coverage changes

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. This needs to be backported to release/v5.1.x. Do we have an auto mergify config for that?

@clevinson clevinson merged commit 3d818cf into main Apr 3, 2024
32 of 34 checks passed
@clevinson clevinson deleted the clev/main-bump-ledger-cosmos-go branch April 3, 2024 00:42
mergify bot pushed a commit that referenced this pull request Apr 3, 2024
(cherry picked from commit 3d818cf)

# Conflicts:
#	go.mod
clevinson added a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.1.x backport to release/v5.1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants