forked from argoproj/argo-cd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App set UI refactor #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
Signed-off-by: reggie <[email protected]>
…rgoproj#14424) Signed-off-by: Gerardo Corea <[email protected]>
…roj#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <[email protected]> * new package name Signed-off-by: Michael Crenshaw <[email protected]> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
…14530) Signed-off-by: mmerrill3 <[email protected]>
…argoproj#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <[email protected]> * fix test Signed-off-by: Alexandre Gaudreault <[email protected]> * fix unit tests Signed-off-by: Alexandre Gaudreault <[email protected]> --------- Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Zechun Chen <[email protected]>
…goproj#11237) Signed-off-by: ylxianzhe <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
* 9353: Restrict scm provider urls Signed-off-by: gmuselli <[email protected]> * 9353: Enforce restriction Signed-off-by: gmuselli <[email protected]> * 9353: Fix after review Signed-off-by: gmuselli <[email protected]> * 9353: Remove comment Signed-off-by: gmuselli <[email protected]> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <[email protected]> * 9353: Code review, update comment Signed-off-by: gmuselli <[email protected]> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <[email protected]> * 9353: Remove doc issues Signed-off-by: gmuselli <[email protected]> * 9353: Fix e2e Signed-off-by: gmuselli <[email protected]> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <[email protected]> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <[email protected]> --------- Signed-off-by: gmuselli <[email protected]> Signed-off-by: Geoffrey Muselli <[email protected]>
…goproj#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…argoproj#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: display valuesobject if set With argoproj#11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <[email protected]> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <[email protected]> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <[email protected]> * chore: eslint Signed-off-by: Blake Pettersson <[email protected]> * chore: eslint Signed-off-by: Blake Pettersson <[email protected]> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <[email protected]> * chore: eslint Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]>
) Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: felix <[email protected]>
Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]>
…argoproj#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](xanzy/go-gitlab@v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](casbin/casbin@v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Dylan Page <[email protected]>
…proj#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West <[email protected]> * Respond to review comments Signed-off-by: Jonathan West <[email protected]> --------- Signed-off-by: Jonathan West <[email protected]>
…4786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis <[email protected]> * Update SECURITY.md Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…j#14780) Signed-off-by: Nathan Romriell <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…notifications engine (argoproj#14761) Signed-off-by: Michael Crenshaw <[email protected]>
… (argoproj#14777) * chore(actions): space instead of hyphen in action name (argoproj#14776) Signed-off-by: Michael Crenshaw <[email protected]> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <[email protected]> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <[email protected]> * delete unused function Signed-off-by: Michael Crenshaw <[email protected]> * revert unnecessary changes Signed-off-by: Michael Crenshaw <[email protected]> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
…oj#14762 (argoproj#14763) Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* Update application.yaml Signed-off-by: Michael Crenshaw <[email protected]> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oproj#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <[email protected]>
…riggers (argoproj#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung <[email protected]> * Use correct nil check Signed-off-by: Trung <[email protected]> * Add missing catalog generation to makefile Signed-off-by: Trung <[email protected]> * Revert changes to update-manifests.sh Signed-off-by: Trung <[email protected]> --------- Signed-off-by: Trung <[email protected]>
Signed-off-by: Keith Chong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.