Keith changes 08 01 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgoproj#16062) (argoproj#16241) * fix(appset): store sha from webhook to get latest change during reconcile (argoproj#16062) Signed-off-by: dhruvang1 <[email protected]> * fix(appset): Don't use revision cache when reconciling after webhook(argoproj#16062) Signed-off-by: dhruvang1 <[email protected]> --------- Signed-off-by: dhruvang1 <[email protected]>
Signed-off-by: gmuselli <[email protected]>
…ssue argoproj#16523) (argoproj#16520) * Update cert-manager.opcertificate health.lua Signed-off-by: Chris Murray <[email protected]> * adding test case for cert issuing Signed-off-by: Chris Murray <[email protected]> * fixing typo Signed-off-by: Chris Murray <[email protected]> --------- Signed-off-by: Chris Murray <[email protected]>
…t platforms (argoproj#16065) Signed-off-by: Ondrej Sika <[email protected]>
Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Wrongly placed horizontal line (`----`) was formatting code-block as a header. Fixed it with a necessary line break Signed-off-by: Elouan Keryell-Even <[email protected]>
Signed-off-by: Phil Nichol <[email protected]>
…6560) Signed-off-by: Jesse Suen <[email protected]>
…proj#16364) Signed-off-by: Rotem Tamir <[email protected]>
… allow app's deletion (argoproj#12172) (argoproj#16506) * fix(appset): remove unnecessary condition Signed-off-by: mikutas <[email protected]> * docs: update explanation about policy Signed-off-by: mikutas <[email protected]> --------- Signed-off-by: mikutas <[email protected]>
Signed-off-by: Jay Shah <[email protected]>
…oj#16581) * chore: upgrade kubernetes dependencies from 0.26.4 to 0.26.11 Fixes some vulnerabilities trivy is reporting on (not necessarily vulnerabe, trivy tends to have a lot of false positives when it comes to golang projects): * CVE-2023-3676 * CVE-2023-3955 * CVE-2023-5528 * CVE-2023-2431 * CVE-2023-2727 * CVE-2023-2728 Signed-off-by: Zoltán Reegn <[email protected]> * go mod tidy Signed-off-by: Zoltán Reegn <[email protected]> * Add go mod tidy to kubernetes updater script Signed-off-by: Zoltán Reegn <[email protected]> --------- Signed-off-by: Zoltán Reegn <[email protected]>
Signed-off-by: Elouan Keryell-Even <[email protected]>
…ns (argoproj#16534) Signed-off-by: dmpe <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
The preserveFileMode isn't under parameters, it should be right under spec. It's correct in the other example here. Signed-off-by: yedayak <[email protected]>
…s ref only (argoproj#16501) * fix(repo-server): excess git requests part 2, short-circuit GenerateManifests ref only Signed-off-by: nromriell <[email protected]> * chore(logging): pr feedback, add debug log to short circuit Signed-off-by: nromriell <[email protected]> * chore: pr feedback, add ref to debug statement Signed-off-by: nromriell <[email protected]> --------- Signed-off-by: nromriell <[email protected]>
…nore wildard customizations (argoproj#16461) Signed-off-by: Ricky McMillen <[email protected]>
So that this can be used for custom resources. The motivation for this is issue argoproj#6008: with this change one should be able to use the known type to ensure equal durations don't present a diff, e,g. via adding to `argocd-cm`: data: resource.customizations.knownTypeFields.cert-manager.io_Certificate: | - field: spec.duration type: meta/v1/Duration This change is based on 5b464c9, though I've included the API version in the type path to be consistent with the generated type (i.e. `meta/v1/Duration` and not `meta/Duration`). For documentation I've just manually listed the extra types that aren't auto-generated, though this requires having to keep this list and the code in-sync but this is probably not a big issue since the number of extra types is not frequently changed. In the tests I've used `require.*` methods since I find this simpler than `if !assert.Blah(...) { return }` which the other tests in this file are using. Signed-off-by: Matthew Hughes <[email protected]>
…on (argoproj#16607) Signed-off-by: Arron Francis <[email protected]>
…goproj#16610) Signed-off-by: Dennis Pan <[email protected]>
Signed-off-by: Robin Lieb <[email protected]>
* docs: add documentation for the argocd cluster commands This adds initial non-reference documentation for the `argocd cluster` commands as part of argoproj#14531. The main goal here is to bootstrap that page and point users wanting to remove the `in-cluster` cluster to the right setting. Signed-off-by: Maurice Meyer <[email protected]> * fixup! docs: add documentation for the argocd cluster commands Signed-off-by: Morre <[email protected]> * fixup! docs: add documentation for the argocd cluster commands Signed-off-by: Maurice Meyer <[email protected]> --------- Signed-off-by: Maurice Meyer <[email protected]> Signed-off-by: Morre <[email protected]>
…t webhook handler (argoproj#16503) (argoproj#16504) * fix: case insensitive comparison of repo details in appset webhook handler Signed-off-by: Sam Greening <[email protected]> * chore(appset test): test case-insensitivity of appset github webhooks Signed-off-by: Sam Greening <[email protected]> * chore(appset test): test case for PR labeled event And fix a couple of spelling errors Signed-off-by: Sam Greening <[email protected]> --------- Signed-off-by: Sam Greening <[email protected]> Co-authored-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* feat: PostDelete hooks support Signed-off-by: Alexander Matyushentsev <[email protected]> --------- Signed-off-by: Alexander Matyushentsev <[email protected]>
…16603) * fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <[email protected]> * fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <[email protected]> * fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <[email protected]> fix(ui): show prompt when using prune option Signed-off-by: ashutosh16 <[email protected]> * chore: update message and simplify code Signed-off-by: Michael Crenshaw <[email protected]> * don't warn on partial sync Signed-off-by: Michael Crenshaw <[email protected]> * fix(ui): lint Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
* feat: Implement Server-Side Diff Signed-off-by: Leonardo Luz Almeida <[email protected]> * propagate the refreshtype to the diff config Signed-off-by: Leonardo Luz Almeida <[email protected]> * Create the serverSideDiff config Signed-off-by: Leonardo Luz Almeida <[email protected]> * chore: add featureflag utility package Signed-off-by: Leonardo Luz Almeida <[email protected]> * remove featureflag package Signed-off-by: Leonardo Luz Almeida <[email protected]> * add param Signed-off-by: Leonardo Luz Almeida <[email protected]> * make ssd configurable with app annotation Signed-off-by: Leonardo Luz Almeida <[email protected]> * add server-side-diff flags Signed-off-by: Leonardo Luz Almeida <[email protected]> * apply the same logic regardless of the refresh type Signed-off-by: Leonardo Luz Almeida <[email protected]> * fix gitops-engine reference Signed-off-by: Leonardo Luz Almeida <[email protected]> * address review comments Signed-off-by: Leonardo Luz Almeida <[email protected]> * Address review comments Signed-off-by: Leonardo Luz Almeida <[email protected]> * docs: add docs related to server-side-diff Signed-off-by: Leonardo Luz Almeida <[email protected]> * docs: update doc Signed-off-by: Leonardo Luz Almeida <[email protected]> * Add config to include mutation webhooks Signed-off-by: Leonardo Luz Almeida <[email protected]> * Address review comments Signed-off-by: Leonardo Luz Almeida <[email protected]> * go mod update Signed-off-by: Leonardo Luz Almeida <[email protected]> * Add sdd cache test case Signed-off-by: Leonardo Luz Almeida <[email protected]> * fix ssd cache unit test Signed-off-by: Leonardo Luz Almeida <[email protected]> * Update clidocs Signed-off-by: Leonardo Luz Almeida <[email protected]> * update manifests Signed-off-by: Leonardo Luz Almeida <[email protected]> * Fix procfile Signed-off-by: Leonardo Luz Almeida <[email protected]> * additional doc changes Signed-off-by: Leonardo Luz Almeida <[email protected]> * update gitops-engine version Signed-off-by: Leonardo Luz Almeida <[email protected]> --------- Signed-off-by: Leonardo Luz Almeida <[email protected]>
* add extension Signed-off-by: Alexy Mantha <[email protected]> * rename to status panel Signed-off-by: Alexy Mantha <[email protected]> * wip Signed-off-by: Alexy Mantha <[email protected]> * cleanup Signed-off-by: Alexy Mantha <[email protected]> * add docs Signed-off-by: Alexy Mantha <[email protected]> * add key Signed-off-by: Alexy Mantha <[email protected]> * fix copy/paste Signed-off-by: Alexy Mantha <[email protected]> * wip Signed-off-by: Alexy Mantha <[email protected]> * flyout Signed-off-by: Alexy Mantha <[email protected]> * cleanup Signed-off-by: Alexy Mantha <[email protected]> * lint Signed-off-by: Alexy Mantha <[email protected]> * document flyout Signed-off-by: Alexy Mantha <[email protected]> * rename Signed-off-by: Alexy Mantha <[email protected]> * linting Signed-off-by: Alexy Mantha <[email protected]> --------- Signed-off-by: Alexy Mantha <[email protected]>
…#16645) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: iam-veeramalla <[email protected]>
Signed-off-by: Robin Lieb <[email protected]>
…r alternative. (argoproj#16690) Signed-off-by: Sanchaai Mathiyarasan <[email protected]>
…ion guide (argoproj#16691) Signed-off-by: Mark Estiller <[email protected]>
…ist (argoproj#16659) Based on https://github.com/argoproj/gitops-engine/blob/master/pkg/sync/hook/delete_policy.go#L13 multiple hook delete policies are also allowed. Signed-off-by: Nenad Strainovic <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
* docs: remove core install commands from getting started I often accidentally run the core install commands when quickly copying and pasting commands from the getting started guide, which leads to confusion. I've also spent plenty of time helping newcomers to Argo CD who have done the same and are confused when they can't reach the UI. Given that this is a "getting started" guide, it's ideal to provide only the commands required. I've removed the commands and left the link out to the core install page for those who are interested in going down that path. Signed-off-by: Nicholas Morey <[email protected]> * fix: use link to install commands in core docs Signed-off-by: Nicholas Morey <[email protected]> * fix: use tip and improve wording Signed-off-by: Nicholas Morey <[email protected]> --------- Signed-off-by: Nicholas Morey <[email protected]>
Signed-off-by: Greg Werner <[email protected]>
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
…ommit (argoproj#16754) Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Missing \ in example Signed-off-by: mfreeman451 <[email protected]>
Signed-off-by: Lie Ryan <[email protected]> Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: Keith Chong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: