Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset cuda-python in python312 migrator #19

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jakirkham
Copy link
Contributor

A bot rerun was requested for cuda-python's 11.8 branch for the python312 migrator ( conda-forge/cuda-python-feedstock#51 ). However the bot never reissued the python312 migrator PR

To address, this PR clears the python312 migrator status from cuda-python so that the bot can try again

@jakirkham
Copy link
Contributor Author

Interesting not sure what to make of the test error on CI:

_____________________ ERROR collecting test_load_graph.py ______________________
ImportError while importing test module '/home/runner/work/cf-graph-countyfair/cf-graph-countyfair/cf-graph/test_load_graph.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/share/miniconda3/envs/cf-scripts/lib/python3.9/site-packages/_pytest/python.py:538: in importtestmodule
    mod = import_path(path, mode=importmode, root=config.rootpath)
/usr/share/miniconda3/envs/cf-scripts/lib/python3.9/site-packages/_pytest/pathlib.py:566: in import_path
    importlib.import_module(module_name)
/usr/share/miniconda3/envs/cf-scripts/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1030: in _gcd_import
    ???
<frozen importlib._bootstrap>:1007: in _find_and_load
    ???
<frozen importlib._bootstrap>:986: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:680: in _load_unlocked
    ???
/usr/share/miniconda3/envs/cf-scripts/lib/python3.9/site-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
test_load_graph.py:2: in <module>
    from conda_forge_tick.utils import setup_logger
E   ImportError: cannot import name 'setup_logger' from 'conda_forge_tick.utils' (/home/runner/work/cf-graph-countyfair/cf-graph-countyfair/cf-scripts/conda_forge_tick/utils.py)

Did some utility used here break something recently?

@jakirkham
Copy link
Contributor Author

cc @beckermr

@beckermr
Copy link
Contributor

beckermr commented Mar 5, 2024

The bot won't come back to non-main migration branches even if this status is reset. Abi migration branches are a "best effort" feature in the bot right now. They are only done when main is done.

@beckermr
Copy link
Contributor

beckermr commented Mar 5, 2024

You cleared everything out which will make the bot come back, but it will attempt to reissue prs for all branches.

Idk about the test failure.

@jakirkham
Copy link
Contributor Author

Having the bot reissue PRs for all branches is ok

It may recognize main has already been migrated. If it doesn't, we can always close the PR

Test failure appears to be due to a breaking change: regro/cf-scripts#2131 (comment)

@beckermr beckermr merged commit 3c24995 into regro:master Mar 6, 2024
1 check failed
@jakirkham jakirkham deleted the reset_cuda-python_py312_br11.8 branch March 6, 2024 00:15
@jakirkham
Copy link
Contributor Author

Thanks Matt! 🙏

@ytausch
Copy link
Contributor

ytausch commented Mar 6, 2024

Regarding the test failure: It is no longer necessary to setup logging with setup_logger and this method is no longer supported. I will submit a PR that fixes the tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants