Mark implicit as not migrated in arch
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beckermr can you please let me know if this is the right way to handle this or if there is a better way? |
1 task
|
It needs to be removed in the pr_json directory. The files there are in sharded dirs that make it annoying to find. |
|
Does this look better or are more changes needed? |
beckermr
approved these changes
Jun 27, 2023
|
Let's make sure the graph loads and then we should be good to go! |
|
Sorry realized I missed one thing (just now pushed) 🤦♂️ Ah ok is graph loading covered by CI or is more testing needed? |
|
Thanks Matt! 🙏 |
|
Seems to have worked as intended ( conda-forge/implicit-feedstock#79 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
implicitfeedstock has only migratedlinux_aarch64. Thelinux_ppc64leportion is not completed yet. So markingimplicitas not migrated in the arch migration.