Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pigz to done in arch migrators #7

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

jakirkham
Copy link
Contributor

@beckermr
Copy link
Contributor

Remember you have to edit the pr info files like last time.

@jakirkham
Copy link
Contributor Author

Sorry Matt. I'm not following. Should there be PRs tracked if the bot errored?

@beckermr
Copy link
Contributor

No but the pre pr migration errors are in those files.

@jakirkham
Copy link
Contributor Author

Ok here are the files I see, which of these should we update?

$ git grep -l 'pigz'
all_feedstocks.json
graph.json
node_attrs/6/6/3/3/3/xopen.json
node_attrs/b/a/3/f/f/makeself.json
node_attrs/d/2/5/f/0/pigz.json
ranked_hubs_authorities.json
status/migration_json/aarch64andppc64leaddition.json
status/migration_json/armosxaddition.json
status/migration_svg/aarch64andppc64leaddition.svg
status/migration_svg/armosxaddition.svg

@beckermr
Copy link
Contributor

That grep doesn't search the file names, only their contents. Look for the file names with the package name and you'll find the right spot.

@jakirkham
Copy link
Contributor Author

Ah ok! That makes more sense 😅 Thanks Matt! 🙏

Now I see

$ git ls-files '*pigz*'
node_attrs/d/2/5/f/0/pigz.json
pr_info/d/2/5/f/0/pigz.json
version_pr_info/d/2/5/f/0/pigz.json
versions/d/2/5/f/0/pigz.json

Take it we want pr_info/d/2/5/f/0/pigz.json, right? Or am I still missing something?

@jakirkham
Copy link
Contributor Author

How does that look?

Also the pr_json/* blobs referenced appear to already be removed. Guessing that is ok? Or do we need to recover those and modify them somehow?

@beckermr
Copy link
Contributor

Look down at the bottom for the pre pr migrator status. Clear that for aarch too.

@jakirkham
Copy link
Contributor Author

Meaning this? It appears empty. Or should the line be deleted altogether?

$ git grep 'pre_pr_migrator_status' -- pr_info/d/2/5/f/0/pigz.json
pr_info/d/2/5/f/0/pigz.json: "pre_pr_migrator_status": {},

@beckermr
Copy link
Contributor

Ohhh weird. Let's merge and see what happens.

@beckermr beckermr merged commit e56a966 into regro:master Oct 14, 2023
1 check passed
@jakirkham jakirkham deleted the mark_pigz_done branch October 14, 2023 01:35
@jakirkham
Copy link
Contributor Author

Sounds good. Thanks again Matt! 🙏

Happy to follow up as needed 🙂

@jakirkham
Copy link
Contributor Author

Looks like the bot added pigz to awaiting PRs for both migrators in commit: 819cc3f

That's a good start. Let's see if it figures out that both are done already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pigz shown in migrator errors, but is already done
2 participants