fix types

conda_forge_tick/lazy_json_backends.py

@@ -58,12 +58,12 @@ def get_sharded_path(file_path, n_dirs=5):
 class LazyJsonBackend(ABC):
     @contextlib.contextmanager
     @abstractmethod
-    def transaction_context(self) -> "LazyJsonBackend":
+    def transaction_context(self) -> "Iterator[LazyJsonBackend]":
         pass
 
     @contextlib.contextmanager
     @abstractmethod
-    def snapshot_context(self) -> "LazyJsonBackend":
+    def snapshot_context(self) -> "Iterator[LazyJsonBackend]":
         pass
 
     @abstractmethod
@@ -108,12 +108,12 @@ def hgetall(self, name: str, hashval: bool = False) -> Dict[str, str]:
 
 class FileLazyJsonBackend(LazyJsonBackend):
     @contextlib.contextmanager
-    def transaction_context(self) -> "FileLazyJsonBackend":
+    def transaction_context(self) -> "Iterator[FileLazyJsonBackend]":
         # context not required
         yield self
 
     @contextlib.contextmanager
-    def snapshot_context(self) -> "FileLazyJsonBackend":
+    def snapshot_context(self) -> "Iterator[FileLazyJsonBackend]":
         # context not required
         yield self
 
@@ -131,7 +131,7 @@ def hmset(self, name: str, mapping: Mapping[str, str]) -> None:
         for key, value in mapping.items():
             self.hset(name, key, value)
 
-    def hmget(self, name: str, keys: str) -> List[str]:
+    def hmget(self, name: str, keys: Iterable[str]) -> List[str]:
         return [self.hget(name, key) for key in keys]
 
     def hgetall(self, name: str, hashval: bool = False) -> Dict[str, str]:
@@ -222,11 +222,11 @@ def _inform_web_request(cls):
                 f"Using the GitHub online backend for making a lot of requests is not recommended.",
             )
 
-    def transaction_context(self) -> "GithubLazyJsonBackend":
+    def transaction_context(self) -> "Iterator[GithubLazyJsonBackend]":
         # context not required
         yield self
 
-    def snapshot_context(self) -> "GithubLazyJsonBackend":
+    def snapshot_context(self) -> "Iterator[GithubLazyJsonBackend]":
         # context not required
         yield self
 
@@ -318,7 +318,7 @@ class MongoDBLazyJsonBackend(LazyJsonBackend):
     _snapshot_session = None
 
     @contextlib.contextmanager
-    def transaction_context(self):
+    def transaction_context(self) -> "Iterator[MongoDBLazyJsonBackend]":
         try:
             if self.__class__._session is None:
                 client = get_graph_data_mongodb_client()
@@ -333,7 +333,7 @@ def transaction_context(self):
             self.__class__._session = None
 
     @contextlib.contextmanager
-    def snapshot_context(self):
+    def snapshot_context(self) -> "Iterator[MongoDBLazyJsonBackend]":
         try:
             if self.__class__._snapshot_session is None:
                 client = get_graph_data_mongodb_client()

tests/test_utils.py

@@ -92,7 +92,6 @@ def test_load_graph():
 
         assert gx.nodes.keys() == {"package1", "package2"}
 
-    mock_file: MagicMock
     mock_file.assert_has_calls([mock.call(DEFAULT_GRAPH_FILENAME)])
 
 
@@ -102,7 +101,6 @@ def test_load_graph_empty_graph():
 
         assert gx is None
 
-    mock_file: MagicMock
     mock_file.assert_has_calls([mock.call(DEFAULT_GRAPH_FILENAME)])
 
 
@@ -113,7 +111,6 @@ def test_load_graph_file_does_not_exist(exists_mock: MagicMock):
     with mock.patch("builtins.open", mock_open(read_data=EMPTY_JSON)) as mock_file:
         load_graph()
 
-    mock_file: MagicMock
     mock_file.assert_has_calls([mock.call(DEFAULT_GRAPH_FILENAME, "w")])
 
 
@@ -123,7 +120,6 @@ def test_load_existing_graph():
 
         assert gx.nodes.keys() == {"package1", "package2"}
 
-    mock_file: MagicMock
     mock_file.assert_has_calls([mock.call(DEFAULT_GRAPH_FILENAME)])
 
 
@@ -132,7 +128,6 @@ def test_load_existing_graph_empty_graph():
         with pytest.raises(ValueError, match="empty JSON"):
             load_existing_graph()
 
-    mock_file: MagicMock
     mock_file.assert_has_calls([mock.call(DEFAULT_GRAPH_FILENAME)])
 
 
@@ -144,5 +139,4 @@ def test_load_existing_graph_file_does_not_exist(exists_mock: MagicMock):
         with pytest.raises(ValueError, match="empty JSON"):
             load_existing_graph()
 
-    mock_file: MagicMock
     mock_file.assert_has_calls([mock.call(DEFAULT_GRAPH_FILENAME, "w")])