Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpiling to es5 #22

Merged
merged 1 commit into from
Jun 19, 2019
Merged

transpiling to es5 #22

merged 1 commit into from
Jun 19, 2019

Conversation

unchai
Copy link
Contributor

@unchai unchai commented Jun 17, 2019

fix #18

@fouad fouad merged commit f04a2f0 into rehooks:master Jun 19, 2019
@slorber
Copy link

slorber commented Jul 18, 2019

hi,

sorry but not sure exactly how you did transpile the lib.

Isn't there a pipeline to transpile from source to target?

What if someone later add a const, will you think about transpiling again?

Asking because the lib did fail for me in IE11 and was not easy to track down what was the cause, and don't want it to happen again, but the process here makes me feel it's likely to happen again

@unchai
Copy link
Contributor Author

unchai commented Jul 19, 2019

@slorber You are right. It can happen again. I can't even do it manually every time. So I added a transpiling pipeline. (#23). I hope that will be merged. 😄

@slorber
Copy link

slorber commented Jul 19, 2019

great thanks for making this more sustainable ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel compiled output contains LET
3 participants