Configure uv to use git commits and tags in cache key #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another attempt to make setuptools-scm work as intended when using the publish to test-pypi workflow. We previously configured setuptools-scm to generate PEP 440-compliant version numbers, and that change enabled a successful push to test-pypi. However, the version number generated by setuptools-scm did not respect the most recent tagged release of Cladetime (v.0.2.3), and assigned a version number of cladetime-0.1.dev1 rather than the expected v.0.2.4.dev[somenumber] The changeset follows uv guidance for using setuptools-scm/dynamic metadata: https://docs.astral.sh/uv/concepts/cache/#dynamic-metadata
zkamvar
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Oh no not cache invalidation!
This looks good to me. This isn't the first time that we've had to work around our tools trying to be helpful and it won't be the last (though I do acknowledge that this is not a workaround and more an explicit customization, but I digress)
Yeaaaah... If this doesn't work, I'll likely ditch uv as the build mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to make setuptools-scm work as intended when using the publish to test-pypi workflow. We previously configured setuptools-scm to generate PEP 440-compliant version numbers, and that change enabled a successful push to test-pypi.
However, the version number generated by setuptools-scm did not respect the most recent tagged release of Cladetime (v.0.2.3), and assigned a version number of cladetime-0.1.dev1 rather than the expected v.0.2.4.dev[somenumber]
The changeset follows uv guidance for using setuptools-scm/dynamic metadata: https://docs.astral.sh/uv/concepts/cache/#dynamic-metadata