Add tests for 2024/25 season endpoints #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lshandross
commented
Nov 22, 2024
Comment on lines
+261
to
+264
| 10000 + floor(0.29 * loc_pop100k), | ||
| 10000 - floor(0.49 * loc_pop100k), | ||
| 10000 + floor(0.69 * loc_pop100k), | ||
| 10000 - floor(0.99 * loc_pop100k) |
There was a problem hiding this comment.
I had copied the test for the 2023/24 season and modified the numbers for 2024/25, but the alternating signs for this portion of the original code (lines 41 to 44) confused me. Should they be alternating here?
Comment on lines
+305
to
+307
| 10000 + floor(2.99 * loc_pop100k), | ||
| 10000 + floor(3.99 * loc_pop100k), | ||
| 10000 + ceiling(1.01 * loc_pop100k) |
There was a problem hiding this comment.
Likewise, I just modified the numbers here, but they didn't seem to be right in the original code (lines 113 to 115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.