Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of horizons for sarix and gbqr models #3

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

elray1
Copy link
Contributor

@elray1 elray1 commented Nov 19, 2024

Fixing a behavior of the outputs:

  • previously, horizons of the output were relative to the last observed data point, which was not in alignment with the flusight format
  • now, horizons are relative to the reference date, as expected for flusight submissions

This required changes to the code, to fix the computations, as well as to the expected outputs for integration tests. Basically, I added 1 to all horizons in the expected output data files.

The integration tests pass for me locally:

=========================================================================== 3 passed, 21 warnings in 66.84s (0:01:06) ===========================================================================

Copy link
Member

@matthewcornell matthewcornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved via live meeting

@elray1 elray1 merged commit a37e9f2 into main Nov 19, 2024
1 check failed
@elray1 elray1 deleted the fix_horizon branch November 19, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants