Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marginal_pit metric #11

Merged
merged 5 commits into from
Oct 22, 2024
Merged

marginal_pit metric #11

merged 5 commits into from
Oct 22, 2024

Conversation

elray1
Copy link
Collaborator

@elray1 elray1 commented Oct 21, 2024

No description provided.

@@ -18,9 +18,11 @@ def energy_score(model_out_wide: pl.DataFrame, obs_data_wide: pl.DataFrame,
obs_data_wide: pl.DataFrame
DataFrame of observed values where each row corresponds to one
(multivariate) observed outcome for one observational unit.
key_cols: list[str]
index_cols: list[str]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to stick with a naming convention throughout the package where key_cols identify an observational unit in the sense of a group of people (location, age group), columns like reference_time_col and time_col refer to time points, and here index_cols includes both key_cols and reference_time_col, since this is what's need to identify a predicted unit.

Copy link
Member

@matthewcornell matthewcornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved via live tour w/ @elray1 and @bsweger

@elray1 elray1 merged commit af7c916 into optimize Oct 22, 2024
1 check passed
@elray1 elray1 deleted the marginal_pit branch October 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants