update XML parser

relaton · Aug 23, 2024 · a879199 · a879199
1 parent 38eb6c1
commit a879199
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/lib/relaton_bib/version.rb b/lib/relaton_bib/version.rb
@@ -1,3 +1,3 @@
 module RelatonBib
-  VERSION = "1.19.3".freeze
+  VERSION = "1.19.4".freeze
 end
diff --git a/lib/relaton_bib/xml_parser.rb b/lib/relaton_bib/xml_parser.rb
@@ -289,13 +289,17 @@ def create_doctype(type)
       # @return [Array<RelatonBib::DocumentIdentifier>]
       def fetch_docid(item)
         item.xpath("./docidentifier").map do |id|
-          did = id.to_h.transform_keys(&:to_sym)
-          did[:id] = id.text
-          did[:primary] = id[:primary] == "true" ? true : nil
-          DocumentIdentifier.new(**did)
+          args = id.to_h.transform_keys(&:to_sym)
+          args[:id] = id.text
+          args[:primary] = id[:primary] == "true" ? true : nil
+          create_docid(**args)
         end
       end
 
+      def create_docid(**args)
+        DocumentIdentifier.new(**args)
+      end
+
       # @param item [Nokogiri::XML::Element]
       # @return [RelatonBib::TypedTitleStringCollection]
       def fetch_titles(item)