WIP

lib/relaton_isbn.rb

@@ -1,7 +1,6 @@
 require "net/http"
 require "relaton_bib"
 require_relative "relaton_isbn/version"
-require_relative "relaton_isbn/config"
 require_relative "relaton_isbn/util"
 require_relative "relaton_isbn/isbn"
 require_relative "relaton_isbn/parser"

lib/relaton_isbn/open_library.rb

@@ -8,22 +8,22 @@ module OpenLibrary
     ENDPOINT = "http://openlibrary.org/api/volumes/brief/isbn/".freeze
 
     def get(ref, _date = nil, _opts = {}) # rubocop:disable Metrics/MethodLength
-      Util.warn "(#{ref}) Fetching from OpenLibrary ..."
+      Util.info "Fetching from OpenLibrary ...", key: ref
 
       isbn = Isbn.new(ref).parse
       unless isbn
-        Util.warn "(#{ref}) Incorrect ISBN."
+        Util.info "Incorrect ISBN.", key: ref
         return
       end
 
       resp = request_api isbn
       unless resp
-        Util.warn "(#{ref}) Not found."
+        Util.info "Not found.", key: ref
         return
       end
 
       bib = Parser.parse resp
-      Util.warn "(#{ref}) Found: `#{bib.docidentifier.first.id}`"
+      Util.info "Found: `#{bib.docidentifier.first.id}`", key: ref
       bib
     end
 

lib/relaton_isbn/util.rb

@@ -1,9 +1,6 @@
 module RelatonIsbn
   module Util
     extend RelatonBib::Util
-
-    def self.logger
-      RelatonIsbn.configuration.logger
-    end
+    PROGNAME = "relaton-isbn".freeze
   end
 end

spec/relaton_isbn/openlibrary_spec.rb

@@ -6,23 +6,23 @@
         bib = double "bib", docidentifier: [double("id", id: "id")]
         expect(RelatonIsbn::Parser).to receive(:parse).with(:doc).and_return bib
         expect(described_class.get("ISBN 9780120644810")).to eq bib
-      end.to output(include("[relaton-isbn] (ISBN 9780120644810) Fetching from OpenLibrary ...",
-                            "[relaton-isbn] (ISBN 9780120644810) Found: `id`")).to_stderr_from_any_process
+      end.to output(include("[relaton-isbn] INFO: (ISBN 9780120644810) Fetching from OpenLibrary ...",
+                            "[relaton-isbn] INFO: (ISBN 9780120644810) Found: `id`")).to_stderr_from_any_process
     end
 
     it "not found" do
       expect do
         expect(described_class).to receive(:request_api).with("9780120644810").and_return nil
         expect(RelatonIsbn::Parser).not_to receive(:parse)
         expect(described_class.get("ISBN 9780120644810")).to be_nil
-      end.to output(include("[relaton-isbn] (ISBN 9780120644810) Not found.")).to_stderr_from_any_process
+      end.to output(include("[relaton-isbn] INFO: (ISBN 9780120644810) Not found.")).to_stderr_from_any_process
     end
 
     it "incorrect ISBN" do
       expect do
         expect(described_class).not_to receive(:request_api)
         expect(described_class.get("ISBN")).to be_nil
-      end.to output(include("[relaton-isbn] (ISBN) Incorrect ISBN.")).to_stderr_from_any_process
+      end.to output(include("[relaton-isbn] INFO: (ISBN) Incorrect ISBN.")).to_stderr_from_any_process
     end
   end