fix(ui): have VersionWithRefresh depend on original data (#516)

release-argus · Jan 15, 2025 · 7d16750 · 7d16750
1 parent 757c716
commit 7d16750
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/web/ui/react-app/src/components/modals/service-edit/version-with-refresh.tsx b/web/ui/react-app/src/components/modals/service-edit/version-with-refresh.tsx
@@ -63,7 +63,7 @@ const VersionWithRefresh: FC<Props> = ({
 		return convertUIDeployedVersionDataEditToAPI(
 			original as DeployedVersionLookupEditType,
 		);
-	}, [serviceID, dataTarget]);
+	}, [original, serviceID, dataTarget]);
 	const url: string | undefined = useWatch({ name: `${dataTarget}.url` });
 	const dataTargetErrors = useErrors(dataTarget, true);
 	const { data, refetchData } = useValuesRefetch(dataTarget);

diff --git a/web/ui/react-app/src/utils/is-empty.tsx b/web/ui/react-app/src/utils/is-empty.tsx
@@ -4,9 +4,8 @@
  * @param arg - The array to check.
  * @returns true when array is empty, null, or undefined. false otherwise.
  */
-export const isEmptyArray = <T extends unknown[] | undefined>(
-	arg: T,
-): boolean => ((arg as unknown[]) ?? []).length === 0;
+export const isEmptyArray = (arg?: unknown[]): arg is [] | undefined =>
+	((arg as unknown[]) ?? []).length === 0;
 
 export const isEmptyObject = <T extends Record<string, unknown> | undefined>(
 	arg: T,